Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding fdroid flavor to build without GMS and Firebase (WPB-2799) (#2727) cherry pick #2813

Merged
merged 4 commits into from Mar 25, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Mar 25, 2024

StoryWPB-2799 Submit wire-android-reloaded to F-Droid

Co-authored-by: Yamil Medina yamilmedina@users.noreply.github.com
Co-authored-by: Mohamad Jaara mohamad.jaara@wire.com

(cherry picked from commit 0e0430d)


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…9) (#2727)

Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
Co-authored-by: Mohamad Jaara <mohamad.jaara@wire.com>

(cherry picked from commit 0e0430d)
Copy link
Contributor

github-actions bot commented Mar 25, 2024

Test Results

812 tests   812 ✅  9m 12s ⏱️
110 suites    0 💤
110 files      0 ❌

Results for commit 47de1dc.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 3739 failed.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Mar 25, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3740 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara merged commit bfc274c into release/candidate Mar 25, 2024
15 checks passed
@MohamadJaara MohamadJaara deleted the feat/fdroid-build branch March 25, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants