Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close properly keyboard in conversation screen [WPB-7630] #2874

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Apr 8, 2024

BugWPB-7630 [Android] Keyboard shows for a short time on conversation list

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
app/src/main/kotlin/com/wire/android/ui/home/conversations/ConversationScreen.kt
app/src/test/kotlin/com/wire/android/ui/home/messagecomposer/state/MessageCompositionInputStateHolderTest.kt
kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • keyboard was focusing when conversation was closing -> added to disable it
  • added to avoid keyboard blinking when textfield collapses

Before

blinking_closing_conversation.mp4
blinking_in_conversation.mp4

After

keyboard_after.mp4

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Test Results

880 tests  ±0   880 ✅ ±0   14m 5s ⏱️ -7s
122 suites ±0     0 💤 ±0 
122 files   ±0     0 ❌ ±0 

Results for commit 9f9f865. ± Comparison against base commit c588bc0.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator Author

Build 4069 failed.

@Garzas Garzas requested review from yamilmedina, Garzas, a team, typfel, borichellow and vitorhugods and removed request for a team April 9, 2024 09:57
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 43.54%. Comparing base (c588bc0) to head (9f9f865).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2874      +/-   ##
===========================================
- Coverage    43.55%   43.54%   -0.01%     
===========================================
  Files          429      429              
  Lines        14078    14081       +3     
  Branches      2443     2443              
===========================================
  Hits          6131     6131              
- Misses        7261     7263       +2     
- Partials       686      687       +1     
Files Coverage Δ
...messagecomposer/state/AdditionalOptionMenuState.kt 51.21% <0.00%> (-1.29%) ⬇️
...essagecomposer/state/MessageComposerStateHolder.kt 60.71% <0.00%> (ø)
...mposer/state/MessageCompositionInputStateHolder.kt 65.76% <0.00%> (-1.21%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c588bc0...9f9f865. Read the comment docs.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 4095 failed.

@Garzas Garzas added this pull request to the merge queue Apr 10, 2024
Merged via the queue into develop with commit 42858fe Apr 10, 2024
11 of 12 checks passed
@Garzas Garzas deleted the fix/close-keyboard-in-conversation-cherry-pick branch April 10, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/S
Projects
None yet
4 participants