Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read conversation on short list [WPB-7432] #2876

Merged
merged 2 commits into from Apr 9, 2024
Merged

fix: read conversation on short list [WPB-7432] #2876

merged 2 commits into from Apr 9, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Apr 9, 2024 •
edited by github-actions bot

BugWPB-7432 [Android] Message not marked as read when received in empty conversation when screen is open

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When list was not scrollable and new message appears being in Conversation Screen conversation was not marked as read

Solutions

Add additional condition to check if list is not scrollable to mark conversation as read when new message appears

@Garzas Garzas self-assigned this Apr 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Test Results

816 tests   816 ✅  9m 49s ⏱️
110 suites    0 💤
110 files      0 ❌

Results for commit c9fb8a4.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4074 succeeded.

The build produced the following APK's:

@Garzas Garzas merged commit ec371a7 into release/candidate Apr 9, 2024
19 checks passed
@Garzas Garzas deleted the fix/read-conversation-on-short-list branch April 9, 2024 07:23
@AndroidBob AndroidBob mentioned this pull request Apr 9, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandreferris alexandreferris alexandreferris approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

@borichellow borichellow Awaiting requested review from borichellow

@mchenani mchenani Awaiting requested review from mchenani

Assignees

@Garzas Garzas

Labels
size/XS
Projects
None yet
Milestone
No milestone
4 participants
@Garzas @AndroidBob @alexandreferris @MohamadJaara