feat: Add option to set user data path #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
requested changes
Sep 14, 2018
electron/js/appInit.js
Outdated
| const EXEC_PATH = process.env.APPIMAGE || process.execPath; | ||
| const USER_PATH = path.join(EXEC_PATH, '..', 'Data'); | ||
| const USER_PATH = path.join(EXEC_PATH, '..', directory); |
There was a problem hiding this comment.
I think it is not going to work if an absolute path is given by the user.
It's going to generate currentDir/../<start of absolute path>
atomrc
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1078 related to #1075 has been hanging around way too long. Sorry about that 馃檲
@ConorIA Since our codebase has evolved and your PR has merge conflicts I simply created a new one. I opted for a naming similar to the start param of Google Chrome (https://chromium.googlesource.com/chromium/src/+/HEAD/docs/user_data_dir.md).
Unless there are strong opinions agains this I would want to merged this and thereby fix and address #1075 and #1078.