fix(env): regression with prod env not being properly read #7714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
reviewed
Mar 27, 2024
atomrc
reviewed
Mar 27, 2024
Comment on lines
54
to
57
| const URL_WEBSITE = { | ||
| PRODUCTION: config.websiteUrl, | ||
| STAGING: 'https://wire-website-staging.zinfra.io', | ||
| STAGING: 'https://wire.com', | ||
| }; |
There was a problem hiding this comment.
I guess we can just use config.websiteUrl for all the case, isn't it?
There was a problem hiding this comment.
if thats the case, lets just remove the isProdEnvironment var
There was a problem hiding this comment.
I'd totally agree with that 👍 Let simplify this
atomrc
reviewed
Mar 27, 2024
Comment on lines
42
to
45
| const isProdEnvironment = | ||
| !!customWebappUrl || | ||
| customWebappUrl === webappEnvironments[ServerType.PRODUCTION].url || | ||
| currentEnvironment === ServerType.PRODUCTION; |
There was a problem hiding this comment.
why changing this condition? Not sure I'm following here 🤔
There was a problem hiding this comment.
this wasnt working correctly before. thats where the regression came from. even in testing i found this condition sort of flakey sometimes (being true at startup but not later), thats why i included several cases.
atomrc
approved these changes
Mar 27, 2024
tlebon
force-pushed
the
fix/update-env-url
branch
from
265465b
to
16a0590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
fixes a regression introduced in #7106
Causes (Optional)
customWebappUrl is not an accurate way to determine if the app is productionEnv. Additionally, staging url has been deprecated.