Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add brewfile to install required tools #664

Merged
merged 7 commits into from
Nov 10, 2023
Merged

Conversation

markusfassbender
Copy link
Contributor

@markusfassbender markusfassbender commented Nov 10, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

As developer one needs to install a bunch of tools via brew, so that Xcode building can work.

Solutions

The Brewfile helps to do all at once and have a list of the required tools.

Testing

How to Test

Run brew bundle on your machine.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@markusfassbender markusfassbender self-assigned this Nov 10, 2023
@markusfassbender markusfassbender marked this pull request as ready for review November 10, 2023 11:04
Copy link
Collaborator

@johnxnguyen johnxnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

Brewfile Outdated Show resolved Hide resolved
@agisilaos agisilaos changed the title feature: add brewfile to install required tools feat: add brewfile to install required tools Nov 10, 2023
Copy link
Contributor

@agisilaos agisilaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@netbe netbe disabled auto-merge November 10, 2023 13:11
@netbe netbe merged commit 817d665 into develop Nov 10, 2023
10 of 11 checks passed
@netbe netbe deleted the feature/add-brewfile branch November 10, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants