Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IdP #1026

Merged
merged 15 commits into from
Apr 16, 2020
Merged

Update IdP #1026

merged 15 commits into from
Apr 16, 2020

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Mar 23, 2020

@fisx fisx force-pushed the fisx/spar-update-idp branch 2 times, most recently from 663fe8a to c949646 Compare April 11, 2020 14:44
@orandev orandev mentioned this pull request Apr 11, 2020
Closed
@fisx fisx force-pushed the fisx/spar-update-idp branch 2 times, most recently from 70b6f67 to bcabe81 Compare April 15, 2020 13:28
@fisx fisx changed the title [WIP] Update IdP Update IdP Apr 15, 2020
@fisx fisx marked this pull request as ready for review April 15, 2020 21:08
mheinzel
mheinzel approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@mheinzel mheinzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it a bit hard to follow the integration test code in some places (tuples everywhere and maybe a bit too much use of abstracted-out functions with many parameters), but I think I managed to understand most of it in the end.

Looks sensible to me.

services/spar/src/Spar/API.hs Outdated Show resolved Hide resolved
@fisx fisx merged commit 7e9cc3b into develop Apr 16, 2020
@fisx fisx deleted the fisx/spar-update-idp branch April 16, 2020 19:26
@fisx fisx mentioned this pull request Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mheinzel mheinzel mheinzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisx @mheinzel