Bump to lts-14.27 #1030
Merged
Bump to lts-14.27 #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We seem to hardcode LTS in CI; do we have to? it's a bit annoying we have to do this in two places |
mheinzel
reviewed
Mar 26, 2020
stack.yaml
Outdated
| - servant-swagger-1.1.7.1@rev:2 | ||
| - swagger2-2.5 | ||
| # - servant-swagger-1.1.7.1@rev:2 | ||
| # - swagger2-2.5 |
There was a problem hiding this comment.
what happened with swagger?
There was a problem hiding this comment.
revision two was added to 14.27 https://www.stackage.org/lts-14.27/package/servant-swagger-1.1.7.1
swagger2-2.5 I accidentally dropped. Good catch. However it still compiles. What was released in 2.5 that we need?
I'll just add it back for now
There was a problem hiding this comment.
@fisx was there a specific reason why we were on 2.5 ? Dropping it to 2.4 worked fine (no dependency conflicts or compiler errors)
There was a problem hiding this comment.
swagger2-2.5 is nice, but not important. I'll see if i can fix the issue upstream, then we can just wait for the next release.
I get very weird compiler errors here swagger2 > /run/user/1000/stack-906dad31b66172ef/swagger2-2.5/src/Data/Swagger/Optics.hs:153:10: error: swagger2 > • Couldn't match type ‘Join swagger2 > A_Lens swagger2 > (IxKind swagger2 > (Data.HashMap.Strict.InsOrd.InsOrdHashMap swagger2 > HttpStatusCode (Referenced Response)))’ swagger2 > with ‘An_AffineTraversal’ swagger2 > arising from a use of ‘%’ swagger2 > • In the expression: #responses % ix n swagger2 > In an equation for ‘ix’: ix n = #responses % ix n swagger2 > In the instance declaration for ‘Ixed Responses’ swagger2 > | swagger2 > 153 | ix n = #responses % ix n swagger2 > | ^^^^^^^^^^^^^^^^^ swagger2 > swagger2 > /run/user/1000/stack-906dad31b66172ef/swagger2-2.5/src/Data/Swagger/Optics.hs:153:23: error: swagger2 > • Couldn't match type ‘IxValue swagger2 > (Data.HashMap.Strict.InsOrd.InsOrdHashMap swagger2 > HttpStatusCode (Referenced Response))’ swagger2 > with ‘Referenced Response’ swagger2 > Expected type: Optic swagger2 > (IxKind swagger2 > (Data.HashMap.Strict.InsOrd.InsOrdHashMap swagger2 > HttpStatusCode (Referenced Response))) swagger2 > NoIx swagger2 > (Data.HashMap.Strict.InsOrd.InsOrdHashMap swagger2 > HttpStatusCode (Referenced Response)) swagger2 > (Data.HashMap.Strict.InsOrd.InsOrdHashMap swagger2 > HttpStatusCode (Referenced Response)) swagger2 > (Referenced Response) swagger2 > (Referenced Response) swagger2 > Actual type: Optic' swagger2 > (IxKind swagger2 > (Data.HashMap.Strict.InsOrd.InsOrdHashMap swagger2 > HttpStatusCode (Referenced Response))) swagger2 > NoIx swagger2 > (Data.HashMap.Strict.InsOrd.InsOrdHashMap swagger2 > HttpStatusCode (Referenced Response)) swagger2 > (IxValue swagger2 > (Data.HashMap.Strict.InsOrd.InsOrdHashMap swagger2 > HttpStatusCode (Referenced Response))) swagger2 > • In the second argument of ‘(%)’, namely ‘ix n’ swagger2 > In the expression: #responses % ix n swagger2 > In an equation for ‘ix’: ix n = #responses % ix n swagger2 > | swagger2 > 153 | ix n = #responses % ix n swagger2 > | ^^^^ swagger2 > swagger2 > /run/user/1000/stack-906dad31b66172ef/swagger2-2.5/src/Data/Swagger/Optics.hs:153:26: error: swagger2 > • Couldn't match type ‘Index swagger2 > (Data.HashMap.Strict.InsOrd.InsOrdHashMap swagger2 > HttpStatusCode (Referenced Response))’ swagger2 > with ‘HttpStatusCode’ swagger2 > Expected type: Index swagger2 > (Data.HashMap.Strict.InsOrd.InsOrdHashMap swagger2 > HttpStatusCode (Referenced Response)) swagger2 > Actual type: Index Responses swagger2 > • In the first argument of ‘ix’, namely ‘n’ swagger2 > In the second argument of ‘(%)’, namely ‘ix n’ swagger2 > In the expression: #responses % ix n swagger2 > | swagger2 > 153 | ix n = #responses % ix n swagger2 > | ^ swagger2 > swagger2 > /run/user/1000/stack-906dad31b66172ef/swagger2-2.5/src/Data/Swagger/Optics.hs:156:10: error: swagger2 > • Couldn't match type ‘IxValue swagger2 > (Data.HashMap.Strict.InsOrd.InsOrdHashMap swagger2 > HttpStatusCode (Referenced Response))’ swagger2 > with ‘Referenced Response’ swagger2 > Expected type: Lens' Responses (Maybe (IxValue Responses)) swagger2 > Actual type: Optic swagger2 > A_Lens swagger2 > NoIx swagger2 > Responses swagger2 > Responses swagger2 > (Maybe swagger2 > (IxValue swagger2 > (Data.HashMap.Strict.InsOrd.InsOrdHashMap swagger2 > HttpStatusCode (Referenced Response)))) swagger2 > (Maybe swagger2 > (IxValue swagger2 > (Data.HashMap.Strict.InsOrd.InsOrdHashMap swagger2 > HttpStatusCode (Referenced Response)))) swagger2 > • In the expression: #responses % at n swagger2 > In an equation for ‘at’: at n = #responses % at n swagger2 > In the instance declaration for ‘At Responses’ swagger2 > | swagger2 > 156 | at n = #responses % at n swagger2 > | ^^^^^^^^^^^^^^^^^ swagger2 > swagger2 > /run/user/1000/stack-906dad31b66172ef/swagger2-2.5/src/Data/Swagger/Optics.hs:156:26: error: swagger2 > • Couldn't match type ‘Index swagger2 > (Data.HashMap.Strict.InsOrd.InsOrdHashMap swagger2 > HttpStatusCode (Referenced Response))’ swagger2 > with ‘HttpStatusCode’ swagger2 > Expected type: Index swagger2 > (Data.HashMap.Strict.InsOrd.InsOrdHashMap swagger2 > HttpStatusCode (Referenced Response)) swagger2 > Actual type: Index Responses swagger2 > • In the first argument of ‘at’, namely ‘n’ swagger2 > In the second argument of ‘(%)’, namely ‘at n’ swagger2 > In the expression: #responses % at n swagger2 > | swagger2 > 156 | at n = #responses % at n swagger2 > | ^ swagger2 >
Yes, that looks redundant, but I don't think it's necessary that the resolver there and the one of wire-server are the same. In the docker image it is just used to build some haskell-related executables, no? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/wireapp/hscim/pull/44
I was wondering if bumping would work without too many changes; and it seems it did :)