Count team members using es #1046
Conversation
One place it is difficult to do is the journaler binary as it doesn't talk to brig as of now.
akshaymankar
force-pushed
the
akshaymankar/count-team-members-using-es
branch
from
a17b33b
to
bdcbc00
Compare
akshaymankar
changed the title
|
Whoops, didn't expect spar to break. Fixing it now. |
| let sizeAfterDelete = | ||
| if sizeBeforeDelete == 0 | ||
| then 0 | ||
| else sizeBeforeDelete - 1 |
There was a problem hiding this comment.
hum, this does not inspire a lot of trust... but i have no idea how to make this better. :(
so if the same thing happens between 1809 and 1810 instead of 0 and 1, the result will be off by one?
There was a problem hiding this comment.
I don't understand what you mean by 1809 and 1810. Can you please explain?
There was a problem hiding this comment.
i mean that if you run into this race condition with number higher than 1 and 0, this will just silently get the count wrong by 1.
Does this accumulate? So every time we enter the count becomes less accurate?
There was a problem hiding this comment.
Yes, this can be off by more than 1, if a lot of people join/leave the team within a very short time (seconds), we are bound to get this number wrong.
Default to 1 if ES says team has 0 users.
Also * Add assertions on error labels * Simplify randomUser functions
Fixes https://github.com/zinfra/backend-issues/issues/1207