Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List team members by UserId #1048

Merged
merged 10 commits into from
Apr 14, 2020
Merged

List team members by UserId #1048

merged 10 commits into from
Apr 14, 2020

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Apr 9, 2020 •
edited by mheinzel

@fisx fisx force-pushed the fisx/bulk-list-team-members-by-id branch from 6489749 to 0cb68c3 Compare April 9, 2020 22:45
mheinzel
mheinzel reviewed Apr 14, 2020
View reviewed changes
Copy link
Contributor

@mheinzel mheinzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things, rest looks good.

services/galley/src/Galley/API.hs Outdated Show resolved Hide resolved
services/galley/src/Galley/API/Teams.hs Show resolved Hide resolved
services/galley/test/integration/API/Teams.hs Outdated Show resolved Hide resolved
@fisx fisx changed the title List team members by UserId [WIP] List team members by UserId Apr 14, 2020
fisx and others added 5 commits April 14, 2020 15:39
@fisx @mheinzel
Update services/galley/src/Galley/API.hs
4a485c3 
Co-Authored-By: Matthias Heinzel <mheinzel@posteo.de>
@fisx
Repair order of auth check and db lookup.
26a4bb6
@fisx @mheinzel
Update services/galley/test/integration/API/Teams.hs
e834b36 
Co-Authored-By: Matthias Heinzel <mheinzel@posteo.de>
@fisx
More test cases.
31627ed
@fisx
Merge branch 'fisx/bulk-list-team-members-by-id' of ssh://github.com/…
f4084d9 
…wireapp/wire-server into fisx/bulk-list-team-members-by-id
@fisx fisx changed the title [WIP] List team members by UserId List team members by UserId Apr 14, 2020
@fisx fisx requested a review from mheinzel April 14, 2020 13:59
mheinzel
mheinzel approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@mheinzel mheinzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fisx fisx merged commit e8f7c10 into develop Apr 14, 2020
@fisx fisx deleted the fisx/bulk-list-team-members-by-id branch April 14, 2020 18:31
This was referenced Apr 15, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mheinzel mheinzel mheinzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisx @mheinzel