Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swagger. #1054

Merged
merged 4 commits into from
Apr 15, 2020
Merged

Fix swagger. #1054

merged 4 commits into from
Apr 15, 2020

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Apr 15, 2020

No description provided.

@mheinzel
Copy link
Contributor

I pushed some other swagger fixes for things I noticed when reviewing this PR.

For the OTR messages, interestingly, the full query parameter descriptions were there for postProtoOtrMessage and postOtrBroadcast, but not the other versions (Proto broadcast and non-Proto conversation message).

fisx
fisx commented Apr 15, 2020
View reviewed changes
Copy link
Contributor Author

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! @mheinzel feel free to merge if it's green and i'm not around.

@mheinzel mheinzel merged commit 608eff1 into develop Apr 15, 2020
@mheinzel mheinzel deleted the fisx/fix-swagger branch April 15, 2020 11:24
@fisx fisx mentioned this pull request Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiago-loureiro tiago-loureiro tiago-loureiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fisx @mheinzel @tiago-loureiro