Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move swagger model to a better place; index it. #1059

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Move swagger model to a better place; index it. #1059

merged 1 commit into from
Apr 16, 2020

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Apr 16, 2020

mheinzel
mheinzel approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@mheinzel mheinzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Btw, did you check if there are any other models that somebody might have forgotten to include? Wouldn't be surprised if we found more.

@fisx
Copy link
Contributor Author

fisx commented Apr 16, 2020

Nice.

Btw, did you check if there are any other models that somebody might have forgotten to include? Wouldn't be surprised if we found more.

I have not, partly because I would really prefer to start migrating this to servant-swagger instead. I'll keep fixing them as somebody stumbles on them.

@fisx fisx merged commit 5f92a27 into develop Apr 16, 2020
@fisx fisx deleted the fisx/fix-swagger branch April 16, 2020 19:24
@fisx fisx mentioned this pull request Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mheinzel mheinzel mheinzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisx @mheinzel