-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spar update issuer #1065
Merged
Merged
spar update issuer #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisx
force-pushed
the
fisx/spar-update-issuer-v1
branch
from
April 20, 2020 07:37
a17a586
to
dbaa123
Compare
fisx
force-pushed
the
fisx/spar-update-issuer-v1
branch
from
April 20, 2020 10:46
728a8a9
to
951b251
Compare
things to think about more:
|
fisx
force-pushed
the
fisx/spar-update-issuer-v1
branch
from
April 20, 2020 12:32
c5cb31e
to
60b8b3d
Compare
fisx
force-pushed
the
fisx/spar-update-issuer-v1
branch
from
April 20, 2020 14:23
a75c138
to
aa58abc
Compare
Merged
jschaul
reviewed
Apr 21, 2020
arianvp
reviewed
Apr 21, 2020
arianvp
reviewed
Apr 21, 2020
arianvp
reviewed
Apr 21, 2020
arianvp
approved these changes
Apr 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/zinfra/backend-issues/issues/929
this took about an hour to hack together, and the only thing that's missing is two functions for lookup users on old issuers and for moving them to the new one. and tests. and i did some cleanup on the way. to be specific:
IdPConfig Teamid
where the type aliasIdP
should be used.now i should probably spend another hour implementing the competing idea of keeping two idps, adding cassandra columns to make the old and the new idp reference each other, and allow for concurrent use of both. right now my gut feeling is that it'll be a lot more work to get right.
UPDATE: I just did them both in one PR, seemed easiest. :)