New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage license headers with headroom instead of licensure #1084
Conversation
This is needed until resolution of the issue: vaclavsvejcar/headroom#42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Does this mean we can also add a check in the PR pipeline for license headers?
Yes, we can add it right now by running Headroom and then checking if any files changed. Or even by checking for There also is an issue for a built-in command, similar to Ormolu's |
Let's do it then :) |
Glad to hear Headroom works for you 👍 Feel free to create new issue if you'll have ideas for new features. I also expect that the mentioned built-in command could be part of one of the next releases. |
Then I'll add a CI check once the command is implemented in Headroom. |
For the most parts, it's a drop in replacement, but it has some advantages.
It's a Haskell tool, so it can be installed (at exactly the version we want) through Stack, the same way as Ormolu.
Also, it knows that we want our Haskell headers after the pragmas (in line with Ormolu's style).
This way:
Thanks a lot to @vaclavsvejcar for adding the features required to make this work!