Federation: Implement ID mapping (brig) #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschaul
reviewed
Jul 15, 2020
jschaul
approved these changes
Jul 15, 2020
mheinzel
force-pushed
the
mheinzel/federation-implement-uuid-mapping-brig
branch
from
1c2e8ee
to
5ecdcfb
Compare
|
Rebased and also added three commits with improvements discussed with @jschaul. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/zinfra/backend-issues/issues/1178
Similar to #1134, but for Brig. Unfortunately we still have a lot of different ways of doing things between Galley and Brig, so it needed some modifications. There's also no nice place to abstract this out, so I think some duplication is okay here.