Refactor: Simplify SRV lookup logic in federation-util #1175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started with the interface of
srvLookup
to avoid dealing with tuples of primitive types infederator
, but quickly continued refactoring the actual logic itself after seeing bit tuples ofWord16
and things like(\(priority', weight', port', domain', _) -> (priority', weight', port', domain'))
andsrvResult''''
.Probably easiest to convince oneself of the correctness by looking at the commits individually.