Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate rex to this repository #1218

Merged
merged 22 commits into from
Oct 21, 2020
Merged

Migrate rex to this repository #1218

merged 22 commits into from
Oct 21, 2020

Conversation

mheinzel
Copy link
Contributor

@mheinzel mheinzel commented Oct 7, 2020

See https://github.com/zinfra/backend-issues/issues/1264.

I have not tried running it yet, but it compiles with the current snapshot.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ mheinzel
✅ jschaul
❌ kim
You have signed the CLA already but the status is still pending? Let us recheck it.

tools/rex/Dockerfile Outdated Show resolved Hide resolved
build: rex

.PHONY: publish
publish: $(ACI) $(ACI).asc s3-exists/$(ACI) s3-upload/$(ACI)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of those targets don't exist anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, and a few more things need fixing.

  • there's an include that doesn't work anymore
  • we should probably stack install into dist as with the other tools

I'm not quite sure how rex is supposed to be packaged/used, so maybe someone else could take care of these outstanding issues with the Makefile?

tools/rex/rex.cabal Outdated Show resolved Hide resolved
tools/rex/.stylish-haskell.yaml Outdated Show resolved Hide resolved
@mheinzel
Copy link
Contributor Author

mheinzel commented Oct 8, 2020

I fixed all of the issues except for the Makefile. Once that's done, this PR should be ready.

2 out of 3 committers have signed the CLA.

Kim worked for Wire when writing this code, so we can go ahead without the CLA.

@jschaul
Copy link
Member

jschaul commented Oct 12, 2020

I added two commits here to put the Makefile in order, add a README, and also to compile a static version based on the current GHC/alpine docker image.

@jschaul
Copy link
Member

jschaul commented Oct 12, 2020

@akshaymankar any further concerns?

Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@mheinzel mheinzel merged commit ce3f5b5 into develop Oct 21, 2020
@mheinzel mheinzel deleted the mheinzel/migrate-rex branch October 21, 2020 14:19
@fisx fisx mentioned this pull request Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants