Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better brig errors #1229

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Better brig errors #1229

merged 1 commit into from
Oct 21, 2020

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Oct 20, 2020

we should be able to distinguish the handful of places where this error is raised [WIP]

@fisx fisx marked this pull request as ready for review October 20, 2020 13:00
@akshaymankar
Copy link
Member

Can we use a better type than Int please? I'd create a special sum type, but even strings are better.

akshaymankar
akshaymankar approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since, this is better than nothing and we don't want to spend time. It is ok to merge.

@fisx fisx merged commit 4208670 into develop Oct 21, 2020
@fisx fisx deleted the fisx/better-errors branch October 21, 2020 09:57
@fisx fisx mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisx @akshaymankar