Fix bug: handle lost after registration of scim-invited users #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisx
approved these changes
Dec 29, 2020
| @@ -283,7 +283,7 @@ testCreateUserNoIdP = do | |||
| >>= maybe (error "could not find user in brig") pure | |||
| liftIO $ accountStatus brigUser `shouldBe` Active | |||
| liftIO $ userManagedBy (accountUser brigUser) `shouldBe` ManagedByScim | |||
|
|
|||
| liftIO $ userHandle (accountUser brigUser) `shouldBe` Just handle | |||
There was a problem hiding this comment.
for the record, without the fix this fails as expected:
test-integration/Test/Spar/Scim/UserSpec.hs:286:14:
1) Spar.Scim.User, POST /Users, team has no SAML IdP, creates a user with PendingInvitation, and user can follow usual invitation process
expected: Just (Handle {fromHandle = "scimuser_8444630"})
but got: Nothing
👍
|
Integration tests passed locally. |
Co-authored-by: fisx <mf@zerobuzz.net>
jschaul
force-pushed
the
SQSERVICES-158/bug-scim-handle-lost
branch
from
5962c26
to
5272cee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bug:
handlevalue from the invitation and thereby overwrites it withnullin the users table. However the user and handle are still containeduser_handlewhich leads to the issue described in https://wearezeta.atlassian.net/browse/SQSERVICES-158This bug can be verified by an additional check in the integeration test for SCIM-invitations.