Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup stack.yaml. #1312

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Cleanup stack.yaml. #1312

merged 1 commit into from
Jan 6, 2021

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Dec 31, 2020

these have been released on hackage two months ago.

@fisx
Copy link
Contributor Author

fisx commented Dec 31, 2020

I stumbled over that when trying to get ghc-8.10 for -Wunused-packages. (No luck there, but at least a bit of cleanup.)

@jschaul
Copy link
Member

jschaul commented Jan 4, 2021

Failures:


  test-integration/Test/Spar/Scim/UserSpec.hs:640:22: 

  1) Spar.Scim.User, POST /Users, team has no SAML IdP, doesn't list users that exceed their invitation period, and allows recreating them

       uncaught exception: ErrorCall

       Assertions failed:

        1: 400 =/= 409

       

       Response was:

       

       Response {responseStatus = Status {statusCode = 409, statusMessage = "Conflict"}, responseVersion = HTTP/1.1, responseHeaders = [("Transfer-Encoding","chunked"),("Date","Thu, 31 Dec 2020 21:52:24 GMT"),("Server","Warp/3.3.13"),("Content-Encoding","gzip"),("Content-Type","application/json")], responseBody = Just "{\"code\":409,\"message\":\"The given e-mail address or phone number is in use.\",\"label\":\"key-exists\"}", responseCookieJar = CJ {expose = []}, responseClose' = ResponseClose}

       CallStack (from HasCallStack):

         error, called at src/Bilge/Assert.hs:88:5 in bilge-0.22.0-LWSwcj5o3J5utdi7oQriS:Bilge.Assert

         <!!, called at test-integration/Util/Invitation.hs:76:7 in main:Util.Invitation

         registerInvitation, called at test-integration/Test/Spar/Scim/UserSpec.hs:640:22 in main:Test.Spar.Scim.UserSpec


  To rerun use: --match "/Spar.Scim.User/POST /Users/team has no SAML IdP/doesn't list users that exceed their invitation period, and allows recreating them/"

@fisx
Copy link
Contributor Author

fisx commented Jan 5, 2021

The error looks very unrelated. @jschaul wanna re-review?

Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green now. Maybe that is a flaky test though? If that flakes again we'd need to deal with it.

@fisx fisx merged commit 4951f7a into develop Jan 6, 2021
@fisx fisx deleted the fisx/bump-deps branch January 6, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants