Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Federation: Convert prekeys endpoints #1372

Merged
merged 31 commits into from
Mar 2, 2021
Merged

Federation: Convert prekeys endpoints #1372

merged 31 commits into from
Mar 2, 2021

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Feb 17, 2021 •
edited
Loading

https://wearezeta.atlassian.net/browse/SQCORE-466

This PR refactors these 3 brig endpoints and adds a qualified version for each one

  • /users/prekeys, with qualified /users/list-prekeys
  • /users/:uid/prekeys, with qualified /users/:domain/:uid/prekeys
  • /users/:uid/prekeys/:client, with qualified /users/:domain/:uid/prekeys/:client

jschaul
jschaul reviewed Feb 17, 2021
View reviewed changes
Copy link
Member

@jschaul jschaul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding nginx routes everywhere! Can we move /list-prekeys to /users/list-prekeys though?

A few nitpicks as inline comments, generally looks good. (I have not looked at the swagger yet though)

services/brig/src/Brig/API/Client.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/API/Client.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/API/Client.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/API/Public.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/API/Public.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/API/Public.hs Show resolved Hide resolved
services/brig/src/Brig/API/Public.hs Outdated Show resolved Hide resolved
@smatting smatting changed the title [skip ci] Federation: Convert prekeys endpoints Federation: Convert prekeys endpoints Feb 22, 2021
@smatting
Copy link
Contributor Author

smatting commented Feb 23, 2021 •
edited
Loading

Thanks for adding nginx routes everywhere! Can we move /list-prekeys to /users/list-prekeys though?

Done

A few nitpicks as inline comments, generally looks good. (I have not looked at the swagger yet though)

I added manual examples in swagger

@smatting smatting mentioned this pull request Mar 1, 2021
Merged
jschaul
jschaul approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@jschaul jschaul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 looks good! Swagger also looks good.

services/brig/src/Brig/API/Error.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/API/Public.hs Outdated Show resolved Hide resolved
@smatting smatting merged commit 59817cc into develop Mar 2, 2021
@smatting smatting deleted the SQCORE-129-prekeys-endpoints branch March 2, 2021 09:34
@akshaymankar akshaymankar mentioned this pull request Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschaul jschaul jschaul approved these changes

@akshaymankar akshaymankar Awaiting requested review from akshaymankar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smatting @akshaymankar @jschaul