Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spar-migrate-data executable #1400

Merged
merged 8 commits into from
Mar 17, 2021
Merged

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Mar 3, 2021

This PR adds spar-migrate-data data migration tool to spar, similar than galley-migrate-data.

It doesn't contain any migrations and running it is a no-op.

This PR also converts the migrate-external-ids executable introduced in #1384 to a migration
that can be added to list of migrations in a future PR.

@smatting smatting requested a review from fisx March 3, 2021 15:46
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of comments, but I don't want to insist on any of them. Ship it or change things first as you deem fit!

services/spar/spar.cabal Outdated Show resolved Hide resolved
services/spar/src/Spar/DataMigration/Options.hs Outdated Show resolved Hide resolved
services/spar/src/Spar/DataMigration/Run.hs Outdated Show resolved Hide resolved
services/spar/src/Spar/DataMigration/Run.hs Outdated Show resolved Hide resolved
services/spar/src/Spar/DataMigration/Types.hs Outdated Show resolved Hide resolved
services/spar/src/Spar/DataMigration/Run.hs Outdated Show resolved Hide resolved
services/spar/src/Spar/DataMigration/V1_ExternalIds.hs Outdated Show resolved Hide resolved
@smatting smatting force-pushed the SQSERVICES-268-spar-migration branch from 3ab3e3e to d8fa883 Compare March 17, 2021 17:28
@smatting smatting merged commit 80b34f1 into develop Mar 17, 2021
@smatting smatting deleted the SQSERVICES-268-spar-migration branch March 17, 2021 19:46
smatting added a commit that referenced this pull request Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants