Fix Arbitrary instances and enable corresponding roundtrip tests #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the empty value cannot be generated. Also re-enable roundtrip tests that were disabled because of this.
pcapriotti
changed the title
pcapriotti
force-pushed
the
pcapriotti/team-update-arbitrary
branch
from
843bc7e
to
b8fcca6
Compare
2 tasks
akshaymankar
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
Arbitraryinstances for types that had flaky JSON roundtrip tests. Here is the list of changes:Millisecondsis a 64 bit integer which is converted to and fromDoublewhen going through JSON encoding. Its arbitrary instance now limits it to values that JSON can represent exactly (up to 2^53).Asset,ResumableAsset,EventandClientMismatchtruncate the times they contain to millisecond precision. TheArbitraryinstance now reflects that.MemberUpdatenever gets serialised (why?). Therefore, the arbitrary instance always sets it toNothing.OtherMemberUpdatecannot beNothing.TeamUpdateDatacannot have all its fields set toNothing.