Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block device handshake in case of LH policy conflict #1526

Merged
merged 83 commits into from
May 28, 2021
Merged

Block device handshake in case of LH policy conflict #1526

merged 83 commits into from
May 28, 2021

Conversation

fisx
Copy link
Contributor

@fisx fisx commented May 24, 2021 •
edited by smatting

https://wearezeta.atlassian.net/browse/SQSERVICES-454

  • ask clients: are clients also explicitely requested? on which api?
  • !! API Changes. Verify that the endpoints are authenticated (Z-User) in all environments
  • Decide whether to implement LH plus federation (includes writing more tests!)

@fisx fisx force-pushed the SQSERVICES-454-lh-block-device-handshake branch from b6dafbf to 6b9dba5 Compare May 25, 2021 07:31
@smatting smatting force-pushed the SQSERVICES-454-lh-block-device-handshake branch 2 times, most recently from e150258 to 90a4ace Compare May 26, 2021 12:53
@fisx fisx mentioned this pull request May 26, 2021
Merged
@fisx
Copy link
Contributor Author

fisx commented May 26, 2021 

* [ ]  Update all routing tables with new internal endpoint

what do you mean? it's an internal end-point, nginz isn't supposed to know about it.

fisx
fisx commented May 26, 2021
View reviewed changes
Copy link
Contributor Author

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm not sure any more about LH+Federation, maybe solving it now is easy enough? I've started reverting it, let's decide tomorrow.

services/galley/src/Galley/API/Update.hs Outdated Show resolved Hide resolved
fisx and others added 23 commits May 27, 2021 09:17
@fisx
...
aea4c7c
@fisx
...
acd26a2
@smatting @fisx
galley: fix compilation
35a7d57
@smatting @fisx
brig: add /i/clients/full endpoint
7fcb4c6
@smatting @fisx
add /i/clients/client-capabilitities/:uid/:client
f44943a
@smatting @fisx
guardLegalholdPolicyConflicts: implement stubs
ec73bd9
@smatting @fisx
add test stub
5be692e
@fisx
Please don't remove my documentation!
9bd5eae
@fisx
Cleanup.
36f49e1
@fisx
Include capabilities in Client.
8cd44b7 
(Reduces number of RPC calls and generally makes things more
straight-forward.  the information isn't that sensitive, and only
available to the owner of the client in the public API.)
@fisx
Renames, comment.
8782922
@fisx
test [wip]
f81c9cf
@fisx
Make sure that LH devices are never treated as old clients.
31f6335
@fisx
Fixup
e3fe4fb
@smatting @fisx
galley: add final log, so you know you didnt miss any
6287540
@smatting @fisx
add test for old client
6950e53
@smatting @fisx
fix test by workaround
6d9fed8
@smatting @fisx
add TODO
94304e1
@smatting @fisx
remove duplicated tests (duplication from rebase)
a6a1464
@smatting @fisx
add test marker
bc7763e
@fisx
guard all places.
d6c3f66
@smatting @fisx
test for legalhold-not-supported
3ea7a7e
@smatting @fisx
...
7e0ccf7
fisx added 3 commits May 27, 2021 21:35
@fisx
Cleanup.
340d6ee 
This way it's more consistent, and we're sure to not miss that spot
when removing the 'LegalholdPlusFederationNotImplemented' in the
course of implementing LH+FD.
@fisx
Work on test.
eaefa45
@fisx
Provoke the test case to fail to validate it.
44caa00
@fisx fisx changed the title Block device handshake in case of LH policy conflict Block device handshake in case of LH policy conflict [skip ci] May 27, 2021
@fisx fisx requested a review from smatting May 27, 2021 20:38
@fisx fisx changed the title Block device handshake in case of LH policy conflict [skip ci] Block device handshake in case of LH policy conflict May 28, 2021
smatting
smatting approved these changes May 28, 2021
View reviewed changes
services/galley/src/Galley/Intra/Client.hs Outdated
@@ -14,9 +14,11 @@
--
-- You should have received a copy of the GNU Affero General Public License along
-- with this program. If not, see <https://www.gnu.org/licenses/>.
{-# OPTIONS_GHC -Wno-deferred-type-errors #-}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: remove this

@smatting smatting merged commit ec54431 into develop May 28, 2021
@smatting smatting deleted the SQSERVICES-454-lh-block-device-handshake branch May 28, 2021 13:40
@fisx fisx mentioned this pull request May 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smatting smatting smatting approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisx @smatting