Qualify users and conversations in Event #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcapriotti
changed the title
pcapriotti
changed the title
Also update examples and golden tests. Consumers of the generated JSON should not be affected, because the fields containing unqualified data are still present in the output.
- Add default value for `conversation_role` field in the schema for `SimpleMember` - Add test to check that the default value above is used - Inline an object schema definition for `SimpleMembers`
pcapriotti
force-pushed
the
pcapriotti/qualified-events
branch
from
e1f14cb
to
669ad09
Compare
pcapriotti
changed the title
jschaul
approved these changes
Jun 3, 2021
| @@ -56,12 +55,12 @@ updateConversationMemberships cmu = do | |||
| when (not (null localUsers)) $ do | |||
| Data.addLocalMembersToRemoteConv localUserIds (cmuConvId cmu) | |||
| -- FUTUREWORK: the resulting event should have qualified users and conversations | |||
There was a problem hiding this comment.
that futurework is done I suppose (feel free to remove this comment only in a follow-up PR though so you don't need to wait for CI again)
This was referenced Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the conversation ID and originating user ID of
Eventqualified, as well as the new member IDs in the case ofMemberJoinevent.The change is pretty big, but there is nothing really going on except adjusting all the places where events are used to make everything type-check. Some functions gained a new
Domainargument which is assumed to be the local domain, in order to be able to qualify IDs.As more and more things become qualified, the need for these ad-hoc qualifications should hopefully reduce.