Fix: Connection type when unblocking after LH #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The redundant test case was hitting an execution path that was not hit before because I was reluctant to call the test with all combinations of options. I'll know better next time, I hope...
Connect convs do not contain the other user, so in order to find the other user it's not good to go through that.
fisx
changed the title
fisx
changed the title
smatting
approved these changes
May 30, 2021
Closed
fisx
added a commit
that referenced
this pull request
Jun 23, 2021
* Import removeTeam to Galley.API.LegalHold without import cycles. (will be needed shortly.) * iterateConversations. (Copied from #1507, which has meanwhile been reverted in #1549.) * Make removeMember device id argument optional. * handleGroupConvPolicyConflicts [wip] * test stub * mapcon * fix bug in handleGroupConvPolicyConflicts * add 2 test cases: who is admin? who gets removed? * Add group conv logic [wip] * move lh helpers to utils * fixup add members * fixup tests * use Conversation from galley to include self * implement anyLHConsentMissing * Move check*Event funs from Teams to Utils * update first * adjust test to new setting & adjust case when peer is admin * hi ci * Add checks for leave events * add testNoConsentCannotBeInvited * add failing test case * Add guards (test succeeds) * refactor: rename guard functions * comment wording * anyLegalholdActivated: make true to the name * adjust testNoConsentRemoveFromGroupConv * inviting conflicting users: adjust and rename test * remove futurework (wont do) and add comments * remove test marker * spell out the tests * add FUTUREWORKs for test structure * comment wording * add test for v2 endpoint * add additional safeguard * Cleanup. * Add two missing test case stubs. * Eliminate redundant negation in function name. * Boolean blindness. only the first line changed, rest is ormolu noise. * Fix call side. * Changed my mind about whether boolean blindness is a good thing. * Fixup. * Cleanup (move source comment to inner block). * Tweak detail. * Remove dubious claim. #1595 (comment) * Simplify. * Move code around. * LH consent: guarantee that all conflicting conv members are removed. * Taking back e16a0bc. (I thought I had spotted a difference in database load, but I think i was wrong, and the original code is more straight-forward.) * Fixup. * Change test cases & descriptions. * fix syntax * All -> Some (explanation in message) Why 1) Because "Some" is the negation of "None" 2) This is consistent with testGroup "Legalhold is activated for user A in a group conversation" * add failing test case * Refactor: factor out new fn getLHStatusForUsers * Update business logic * Remove NoConsentingAdmins test case * Add test case: mixed invitees * Refactor: group tests regarding invite together * assertion (it's non-trivial, but easy enough to convince ourselves that it'll pass fine, so no error handling needed.) * Language. Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See haddocks for
RelationWithHistoryfor more info. Fixes a bug introduced here that can only be triggered if legalhold is enabled (not the default).