Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display helm test logs interactively #1700

Merged
merged 7 commits into from
Aug 16, 2021
Merged

Display helm test logs interactively #1700

merged 7 commits into from
Aug 16, 2021

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Aug 9, 2021 •
edited

Use kubectl logs -f to display test output while integration tests are running.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • Section Unreleased of CHANGELOG.md contains the following bits of information:
    • A line with the title and number of the PR in one or more suitable sub-sections.

akshaymankar
akshaymankar approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I am paranoid about bash so I would recommend adding set -euo pipefail everywhere.

hack/bin/integration-test.sh Outdated Show resolved Hide resolved
hack/bin/integration-test-logs.sh Outdated Show resolved Hide resolved
@pcapriotti pcapriotti force-pushed the pcapriotti/interactive-integration-logs branch from b90e8fd to ee26624 Compare August 13, 2021 12:32
@akshaymankar akshaymankar merged commit 7cf79c1 into develop Aug 16, 2021
@akshaymankar akshaymankar deleted the pcapriotti/interactive-integration-logs branch August 16, 2021 15:07
pcapriotti added a commit that referenced this pull request Sep 8, 2021
@pcapriotti
Revert hack to display helm test output
9304458 
The hack in #1700 does not actually seem to work in CI, and in fact it
prevents log output from being displayed at all when helm test fails.

The integration-test-logs.sh script is still around, and it can be used
to display helm test output interactive when running tests manually in a
terminal.
@pcapriotti pcapriotti mentioned this pull request Sep 8, 2021
Merged
2 tasks
pcapriotti added a commit that referenced this pull request Sep 8, 2021
@pcapriotti
Revert hack to display helm test output
8239b2c 
The hack in #1700 does not actually seem to work in CI, and in fact it
prevents log output from being displayed at all when helm test fails.

The integration-test-logs.sh script is still around, and it can be used
to display helm test output interactive when running tests manually in a
terminal.
@akshaymankar akshaymankar mentioned this pull request Sep 8, 2021
Merged
pcapriotti added a commit that referenced this pull request Sep 8, 2021
@pcapriotti
Revert hack to display helm test output (#1742)
858c197 
The hack in #1700 does not actually seem to work in CI, and in fact it
prevents log output from being displayed at all when helm test fails.

The integration-test-logs.sh script is still around, and it can be used
to display helm test output interactive when running tests manually in a
terminal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pcapriotti @akshaymankar