-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Servantify brig properties endpoints #2244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcapriotti
force-pushed
the
pcapriotti/servantify-brig-properties
branch
from
March 31, 2022 15:04
5634f2f
to
614adc0
Compare
akshaymankar
reviewed
Apr 6, 2022
pcapriotti
force-pushed
the
pcapriotti/servantify-brig-properties
branch
from
April 6, 2022 13:24
c0c5b61
to
094c40d
Compare
pcapriotti
force-pushed
the
pcapriotti/servantify-brig-properties
branch
from
April 6, 2022 13:26
094c40d
to
fc7cdcc
Compare
akshaymankar
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR servantifies brig's properties endpoints.
A couple of things worth noting:
GET /properties
) was used to test/i/metrics
. This role has now been taken by/onboarding/v3
(arbitrarily).RawPropertyValue
wrapper around aByteString
, which leaves it to the handler to do the actual parsing and validation.As a side note, it is a bit strange that we are parsing property values at all, since we just convert them back to bytestrings immediately to save them in the database, and never look inside again. In principle, we could make them completely opaque bytestrings and avoid having to deal with all of these complications. However, it is hard to do without changing the API somehow, since these values are used inside other JSON objects.
Checklist
changelog.d
.