Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FS-207] MLS Message Propagation #2253

Merged
merged 11 commits into from
Apr 13, 2022
Merged

[FS-207] MLS Message Propagation #2253

merged 11 commits into from
Apr 13, 2022

Conversation

mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Mar 31, 2022 •
edited

This implements local message validation and forwarding.

The PR is part of https://wearezeta.atlassian.net/browse/FS-207.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from e5a369f to 3b750b0 Compare March 31, 2022 19:42
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-endpoint branch from 0643ae1 to 4765a8a Compare April 4, 2022 13:38
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from 3b750b0 to 5a1a570 Compare April 4, 2022 13:48
@mdimjasevic mdimjasevic temporarily deployed to cachix April 4, 2022 13:48 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from 5a1a570 to 84a4eb2 Compare April 4, 2022 13:57
@mdimjasevic mdimjasevic temporarily deployed to cachix April 4, 2022 13:57 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from 84a4eb2 to 98ccdf4 Compare April 4, 2022 14:39
@mdimjasevic mdimjasevic temporarily deployed to cachix April 4, 2022 14:39 Inactive
@pcapriotti pcapriotti mentioned this pull request Apr 5, 2022
Merged
16 tasks
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from 98ccdf4 to ea47d20 Compare April 5, 2022 06:48
@mdimjasevic mdimjasevic temporarily deployed to cachix April 5, 2022 06:49 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-endpoint branch from 4765a8a to 3fe68d4 Compare April 5, 2022 07:01
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from ea47d20 to 9884ea7 Compare April 5, 2022 07:04
@mdimjasevic mdimjasevic temporarily deployed to cachix April 5, 2022 07:04 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-endpoint branch from 3fe68d4 to a65b2dd Compare April 5, 2022 07:54
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from 9884ea7 to e474993 Compare April 5, 2022 08:11
@mdimjasevic mdimjasevic temporarily deployed to cachix April 5, 2022 08:12 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix April 5, 2022 08:38 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from a3f7415 to 741a905 Compare April 5, 2022 08:52
@mdimjasevic mdimjasevic temporarily deployed to cachix April 5, 2022 08:52 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from 741a905 to b4725f2 Compare April 5, 2022 09:04
@mdimjasevic mdimjasevic temporarily deployed to cachix April 5, 2022 09:04 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-endpoint branch 2 times, most recently from 971e2ee to 5475f42 Compare April 5, 2022 10:04
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from b4725f2 to 967f99b Compare April 5, 2022 11:38
@mdimjasevic mdimjasevic temporarily deployed to cachix April 5, 2022 11:38 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-endpoint branch from 5475f42 to 5d03757 Compare April 5, 2022 11:57
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from 967f99b to 5acf461 Compare April 5, 2022 12:31
@mdimjasevic mdimjasevic temporarily deployed to cachix April 5, 2022 12:31 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from 5acf461 to 92dc9ee Compare April 5, 2022 12:42
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from 9f47cc0 to 4931633 Compare April 8, 2022 11:48
@mdimjasevic mdimjasevic temporarily deployed to cachix April 8, 2022 11:48 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from 4931633 to 8fcab07 Compare April 11, 2022 12:14
@mdimjasevic mdimjasevic temporarily deployed to cachix April 11, 2022 12:14 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from 8fcab07 to f24ec04 Compare April 11, 2022 14:43
@mdimjasevic mdimjasevic temporarily deployed to cachix April 11, 2022 14:43 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix April 12, 2022 12:49 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix April 12, 2022 13:58 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix April 12, 2022 14:20 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-207/mls-application-message-propagation branch from 023403b to be75909 Compare April 12, 2022 14:59
@mdimjasevic mdimjasevic temporarily deployed to cachix April 12, 2022 14:59 Inactive
@mdimjasevic mdimjasevic marked this pull request as ready for review April 12, 2022 14:59
@mdimjasevic mdimjasevic changed the title [FS-207] MLS Application Message Propagation [FS-207] MLS Message Propagation Apr 12, 2022
@mdimjasevic mdimjasevic temporarily deployed to cachix April 12, 2022 15:06 Inactive
pcapriotti
pcapriotti approved these changes Apr 13, 2022
View reviewed changes
libs/wire-api/src/Wire/API/MLS/Message.hs
Comment on lines +164 to +169
-- | Identify the content type of a message payload to be signed.
mpTag :: MessagePayloadTBS -> ContentType
mpTag (ApplicationMessage _) = ApplicationMessageTag
mpTag (ProposalMessage _) = ProposalMessageTag
mpTag (CommitMessage _) = CommitMessageTag

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the refactored code it wasn't used. You just merged it so I guess we can remove it in some other PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm working on a follow up PR anyway, it's quicker to just merge as is rather than waiting for CI again and having to deal with stacked PRs in the meantime.

@pcapriotti pcapriotti merged commit 755a791 into develop Apr 13, 2022
@pcapriotti pcapriotti deleted the fs-207/mls-application-message-propagation branch April 13, 2022 08:01
@zebot zebot mentioned this pull request Apr 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdimjasevic @pcapriotti