Suspend non-existing user should not create DB entry and return 404 #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaymankar
requested changes
Apr 6, 2022
services/brig/src/Brig/Data/User.hs
Outdated
Comment on lines
344
to
348
| updateStatus u s = | ||
| whenM (userExists u) $ retry x5 $ write userStatusUpdate (params LocalQuorum (s, u)) | ||
| where | ||
| userExists :: MonadClient m => UserId -> m Bool | ||
| userExists uid = isJust <$> retry x1 (query1 idSelect (params LocalQuorum (Identity uid))) |
There was a problem hiding this comment.
Can you please make this throw a 404 when the user doesn't exist? Otherwise someone using the backoffice might think they did what was necessary when in reality it was a typo.
battermann
force-pushed
the
leif/fix-suspend
branch
from
2657e4b
to
10c6994
Compare
battermann
changed the title
akshaymankar
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.