Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make internal search-visibility endpoint available to staging environments #2282

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Make internal search-visibility endpoint available to staging environments #2282

merged 3 commits into from
Apr 12, 2022

Conversation

smatting
Copy link
Contributor

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@smatting smatting temporarily deployed to cachix April 12, 2022 16:02 Inactive
@smatting smatting changed the title Make internal search-visiblity endpoint available to staging environments Make internal search-visibility endpoint available to staging environments Apr 12, 2022
@stephen-smith
Copy link
Contributor

Are corresponding changes necessary for demo in deploy/services-demo/conf/nginz/nginx.conf ?

@smatting smatting temporarily deployed to cachix April 12, 2022 16:08 Inactive
@smatting smatting merged commit 5dca370 into develop Apr 12, 2022
@smatting smatting deleted the smatting/staging-expose-search-visibility branch April 12, 2022 16:11
supersven
supersven reviewed Apr 12, 2022
View reviewed changes
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@zebot zebot mentioned this pull request Apr 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersven supersven supersven left review comments

@stephen-smith stephen-smith stephen-smith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smatting @stephen-smith @supersven