Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip_own param to MLS kp claiming endpoint #2287

Merged
merged 5 commits into from
Apr 20, 2022
Merged

Add skip_own param to MLS kp claiming endpoint #2287

merged 5 commits into from
Apr 20, 2022

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Apr 13, 2022 •
edited

Clients need to claim key packages for other clients of the same user, but never their own. This adds a skip_own query parameter to the key package claiming endpoint, which can be used to prevent wasting a key package for the requesting client.

Tracked by https://wearezeta.atlassian.net/browse/FS-527.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@pcapriotti pcapriotti temporarily deployed to cachix April 13, 2022 12:33 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix April 14, 2022 06:28 Inactive
mdimjasevic
mdimjasevic approved these changes Apr 14, 2022
View reviewed changes
libs/wire-api/src/Wire/API/Routes/Public/Brig.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/API/MLS/KeyPackages.hs Outdated Show resolved Hide resolved
services/brig/test/integration/API/MLS.hs Show resolved Hide resolved
@pcapriotti pcapriotti temporarily deployed to cachix April 14, 2022 12:54 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix April 14, 2022 12:54 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix April 19, 2022 06:08 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix April 19, 2022 12:46 Inactive
pcapriotti and others added 5 commits April 19, 2022 16:03
@pcapriotti
Add skip_own param to MLS kp claiming endpoint
f7cb795 
Clients need to claim key packages for other clients of the same user,
but never their own. This adds a `skip_own` query parameter to the key
package claiming endpoint, which can be used to prevent wasting a key
package for the requesting client.
@pcapriotti
Add CHANGELOG entry
ba631ae
@pcapriotti @mdimjasevic
Typo
334bedd 
Co-authored-by: Marko Dimjašević <marko.dimjasevic@wire.com>
@pcapriotti @mdimjasevic
Remove trace statement
eac45f2 
Co-authored-by: Marko Dimjašević <marko.dimjasevic@wire.com>
@pcapriotti
Add one more kp claim assertion in MLS test
21e1109
@pcapriotti pcapriotti temporarily deployed to cachix April 19, 2022 14:04 Inactive
@pcapriotti pcapriotti merged commit 4174940 into develop Apr 20, 2022
@pcapriotti pcapriotti deleted the pcapriotti/mls-skip-claim branch April 20, 2022 09:31
@zebot zebot mentioned this pull request Apr 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdimjasevic mdimjasevic mdimjasevic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pcapriotti @mdimjasevic