Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Feature Configuration #2435

Merged
merged 28 commits into from
Jun 16, 2022
Merged

Conversation

smatting
Copy link
Contributor

@smatting smatting commented May 30, 2022

https://wearezeta.atlassian.net/browse/SQSERVICES-658

  • Remove FeatureTag type completely

Checklist

  • Delete all commented-out code
  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@battermann battermann changed the title Simplify Feature Configuration Simplify Feature Configuration [skip ci] May 31, 2022
@smatting
Copy link
Contributor Author

smatting commented Jun 7, 2022

3 tests still fail

    service whitelist
      search permissions:                                                              [galley] E, IO Exception occurred, message=Error {code = Status {statusCode = 403, statusMessage = "Forbidden"}, label = "operation-denied", message = "Insufficient permissions", errorData = Nothing}, request=N/A
[brig] E, IO Exception occurred, message=responseJsonUnsafeWithMsg: WithStatus SndFactorPasswordChallengeConfig Error in $: key "status" not found CallStack (from HasCallStack):   error, called at src/Bilge/Response.hs:143:7 in bilge-0.22.0-inplace:Bilge.Response   responseJsonUnsafeWithMsg, called at src/Bilge/Response.hs:132:22 in bilge-0.22.0-inplace:Bilge.Response   responseJsonUnsafe, called at src/Brig/IO/Intra.hs:1405:3 in brig-2.0-inplace:Brig.IO.Intra, request=N/A
[brig] E, code=500, label=server-error, request=N/A, "Server Error"
FAIL
        Exception: Assertions failed:
         1: 200 =/= 500
        
        Response was:
        
        Response {responseStatus = Status {statusCode = 500, statusMessage = "Internal Server Error"}, responseVersion = HTTP/1.1, responseHeaders = [("Transfer-Encoding","chunked"),("Date","Tue, 07 Jun 2022 15:59:54 GMT"),("Server","Warp/3.3.17"),("Vary","Accept-Encoding"),("Content-Encoding","gzip"),("Content-Type","application/json")], responseBody = Just "{\"code\":500,\"label\":\"server-error\",\"message\":\"Server Error\"}", responseCookieJar = CJ {expose = []}, responseClose' = ResponseClose}
        CallStack (from HasCallStack):
          error, called at src/Bilge/Assert.hs:89:5 in bilge-0.22.0-inplace:Bilge.Assert
          <!!, called at src/Bilge/Assert.hs:107:19 in bilge-0.22.0-inplace:Bilge.Assert
          !!!, called at test/integration/API/Provider.hs:749:3 in main:API.Provider
        Use -p '/search permissions/' to rerun this test only.
      update permissions:                                                              FAIL
        Exception: Assertions failed:
         1: 403 =/= 500
         2: Just "insufficient-permissions" =/= Just "server-error"
        
        Response was:
      search:                                                                          [galley] E, IO Exception occurred, message=Error {code = Status {statusCode = 403, statusMessage = "Forbidden"}, label = "operation-denied", message = "Insufficient permissions", errorData = Nothing}, request=N/A
[brig] E, IO Exception occurred, message=responseJsonUnsafeWithMsg: WithStatus SndFactorPasswordChallengeConfig Error in $: key "status" not found CallStack (from HasCallStack):   error, called at src/Bilge/Response.hs:143:7 in bilge-0.22.0-inplace:Bilge.Response   responseJsonUnsafeWithMsg, called at src/Bilge/Response.hs:132:22 in bilge-0.22.0-inplace:Bilge.Response   responseJsonUnsafe, called at src/Brig/IO/Intra.hs:1405:3 in brig-2.0-inplace:Brig.IO.Intra, request=N/A
[brig] E, code=500, label=server-error, request=N/A, "Server Error"
FAIL
        Exception: Assertions failed:
         1: 200 =/= 500

@battermann battermann changed the title Simplify Feature Configuration [skip ci] Simplify Feature Configuration Jun 8, 2022
@smatting smatting force-pushed the smatting/simplify-feature-configs branch 2 times, most recently from 7749eca to 2339968 Compare June 9, 2022 09:17
@smatting smatting temporarily deployed to cachix June 9, 2022 09:17 Inactive
@battermann battermann temporarily deployed to cachix June 9, 2022 09:21 Inactive
@battermann battermann temporarily deployed to cachix June 9, 2022 09:29 Inactive
@battermann battermann temporarily deployed to cachix June 9, 2022 09:40 Inactive
@smatting smatting temporarily deployed to cachix June 9, 2022 09:42 Inactive
@battermann battermann temporarily deployed to cachix June 9, 2022 09:46 Inactive
@smatting smatting temporarily deployed to cachix June 9, 2022 10:10 Inactive
@battermann battermann temporarily deployed to cachix June 9, 2022 10:43 Inactive
@smatting smatting temporarily deployed to cachix June 9, 2022 10:43 Inactive
@smatting smatting temporarily deployed to cachix June 9, 2022 11:09 Inactive
@smatting smatting temporarily deployed to cachix June 9, 2022 13:32 Inactive
@battermann battermann temporarily deployed to cachix June 9, 2022 13:48 Inactive
@battermann battermann temporarily deployed to cachix June 9, 2022 14:09 Inactive
@smatting smatting temporarily deployed to cachix June 9, 2022 14:42 Inactive
@smatting smatting temporarily deployed to cachix June 9, 2022 14:55 Inactive
@smatting smatting force-pushed the smatting/simplify-feature-configs branch from 42a8bbd to 1bc55b1 Compare June 9, 2022 15:39
@smatting smatting temporarily deployed to cachix June 9, 2022 15:39 Inactive
@smatting smatting temporarily deployed to cachix June 9, 2022 16:16 Inactive
@battermann battermann temporarily deployed to cachix June 10, 2022 09:47 Inactive
@battermann battermann marked this pull request as ready for review June 10, 2022 09:47
@battermann battermann temporarily deployed to cachix June 10, 2022 09:55 Inactive
@battermann battermann temporarily deployed to cachix June 10, 2022 09:57 Inactive
@battermann battermann requested review from fisx and pcapriotti and removed request for fisx June 10, 2022 09:57
@battermann battermann force-pushed the smatting/simplify-feature-configs branch from 9316215 to 3a82615 Compare June 16, 2022 08:36
@battermann battermann temporarily deployed to cachix June 16, 2022 08:36 Inactive
@battermann battermann temporarily deployed to cachix June 16, 2022 08:45 Inactive
@smatting smatting temporarily deployed to cachix June 16, 2022 11:27 Inactive
@battermann battermann temporarily deployed to cachix June 16, 2022 13:22 Inactive
@battermann battermann temporarily deployed to cachix June 16, 2022 13:26 Inactive
@battermann battermann temporarily deployed to cachix June 16, 2022 14:32 Inactive
Copy link
Contributor Author

@smatting smatting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants