Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of creator client in MLS conversations #2486

Merged
merged 13 commits into from
Jun 16, 2022

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Jun 15, 2022

When an MLS conversation is created, it implicitly contains the creator client as a member. This was not reflected in the database. This PR fixes the problem as follows:

  • it requires a creator_client field when a conversation is created, and uses it to record the creator client as a member of the conversation
  • it associates the key package ref of the creator to that client when the first commit is processed.

This required changing the conversation creation endpoint POST /conversations. The change is only visible in v2.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2022

CLA assistant check
All committers have signed the CLA.

@pcapriotti pcapriotti temporarily deployed to cachix June 15, 2022 12:23 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix June 15, 2022 13:05 Inactive
@flokli
Copy link
Contributor

flokli commented Jul 15, 2022

This accidentially reverted the submodule bump in nginx-module-vts.

flokli added a commit that referenced this pull request Jul 15, 2022
@flokli
Copy link
Contributor

flokli commented Jul 15, 2022

PR to undo in #2566.

jschaul pushed a commit that referenced this pull request Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants