-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of creator client in MLS conversations #2486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcapriotti
force-pushed
the
pcapriotti/mls-conflict-fix
branch
from
June 15, 2022 12:22
5dbbedf
to
2668487
Compare
stefanwire
approved these changes
Jun 15, 2022
This was referenced Jul 5, 2022
This accidentially reverted the submodule bump in |
flokli
added a commit
that referenced
this pull request
Jul 15, 2022
…dule bump This was accidentially reverted in #2486
13 tasks
PR to undo in #2566. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an MLS conversation is created, it implicitly contains the creator client as a member. This was not reflected in the database. This PR fixes the problem as follows:
creator_client
field when a conversation is created, and uses it to record the creator client as a member of the conversationThis required changing the conversation creation endpoint
POST /conversations
. The change is only visible in v2.Checklist
changelog.d
.