Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqservices 1529 remove redundant endpoints internal and view feature permissions #2496

Merged
merged 6 commits into from
Jun 23, 2022
Merged

Sqservices 1529 remove redundant endpoints internal and view feature permissions #2496

merged 6 commits into from
Jun 23, 2022

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Jun 20, 2022 •
edited

https://wearezeta.atlassian.net/browse/SQSERVICES-1529

Removed the following deprecated internal endpoints, which are neither used within wire-server, nor by ibis, nor by stern:

  • PUT i/teams/:tid/features/search-visibility
  • GET i/teams/:tid/features/search-visibility
  • PUT i/teams/:tid/features/validate-saml-emails
  • GET i/teams/:tid/features/validate-saml-emails
  • PUT i/teams/:tid/features/digital-signatures
  • GET i/teams/:tid/features/digital-signatures

This PR also removes redundant permission checks for viewing features

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@battermann battermann temporarily deployed to cachix June 20, 2022 14:29 Inactive
@battermann battermann temporarily deployed to cachix June 21, 2022 07:00 Inactive
@battermann battermann temporarily deployed to cachix June 21, 2022 07:01 Inactive
@battermann battermann marked this pull request as ready for review June 21, 2022 07:01
@battermann battermann requested a review from fisx June 21, 2022 07:01
@battermann battermann temporarily deployed to cachix June 21, 2022 07:16 Inactive
@battermann battermann temporarily deployed to cachix June 21, 2022 07:46 Inactive
@battermann battermann temporarily deployed to cachix June 21, 2022 14:57 Inactive
@battermann battermann requested a review from smatting June 21, 2022 14:57
@battermann battermann force-pushed the SQSERVICES-1529-remove-redundant-endpoints-internal branch from e13442e to 6ff6923 Compare June 22, 2022 09:04
@battermann battermann temporarily deployed to cachix June 22, 2022 09:04 Inactive
smatting
smatting approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@smatting smatting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also removes redundant permission checks for viewing features. Can you please update or title of the PR accordingly?

@battermann battermann changed the title Sqservices 1529 remove redundant endpoints internal Sqservices 1529 remove redundant endpoints internal and view feature permissions Jun 23, 2022
@battermann battermann merged commit bfc329f into develop Jun 23, 2022
@battermann battermann deleted the SQSERVICES-1529-remove-redundant-endpoints-internal branch June 23, 2022 08:56
This was referenced Jul 5, 2022
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smatting smatting smatting approved these changes

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@battermann @smatting @fisx