Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed flakiness of a test by adding a clean-up step at the end. #2497

Merged
merged 4 commits into from
Jun 21, 2022

Conversation

elland
Copy link
Contributor

@elland elland commented Jun 20, 2022

As the code comment hints at, we have a very narrow window between a user being created and the account being suspended inside the test environment. For a good reason too. We don't want to run a test that takes too long to check that account suspension works. But a suspended account can no longer be updated, rendering this particular test flaky, especially on subsequent test suite runs.

This should address that issue but immediately cleaning up after itself.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.

@elland elland temporarily deployed to cachix June 20, 2022 14:48 Inactive
@elland elland marked this pull request as ready for review June 21, 2022 07:25
Copy link
Contributor

@battermann battermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
it's a really small change, but I think we still want a changelog entry

services/brig/test/integration/API/User/Account.hs Outdated Show resolved Hide resolved
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
@elland elland temporarily deployed to cachix June 21, 2022 07:31 Inactive
@elland elland temporarily deployed to cachix June 21, 2022 07:40 Inactive
@mdimjasevic
Copy link
Contributor

Today I noticed the same test being flaky so thank you for taking care of it, @elland !

@elland elland temporarily deployed to cachix June 21, 2022 09:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants