Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brig-types: remove all re-exports #2505

Merged
merged 10 commits into from
Jun 24, 2022
Merged

brig-types: remove all re-exports #2505

merged 10 commits into from
Jun 24, 2022

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Jun 22, 2022 •
edited

https://wearezeta.atlassian.net/browse/BE-567

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):

@smatting smatting temporarily deployed to cachix June 22, 2022 16:24 Inactive
@smatting smatting temporarily deployed to cachix June 23, 2022 08:54 Inactive
@smatting smatting force-pushed the smatting/brig-types-remove-reexports branch from 970842a to 3f49b00 Compare June 23, 2022 08:56
@smatting smatting temporarily deployed to cachix June 23, 2022 08:56 Inactive
@smatting smatting requested a review from elland June 23, 2022 08:57
@smatting smatting changed the title brig-types: remove re-exports brig-types: remove all re-exports Jun 23, 2022
@smatting smatting marked this pull request as ready for review June 23, 2022 08:57
pcapriotti
pcapriotti approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I haven't looked at it too carefully.

@smatting smatting merged commit 2e1290d into develop Jun 24, 2022
@smatting smatting deleted the smatting/brig-types-remove-reexports branch June 24, 2022 07:31
This was referenced Jul 5, 2022
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elland elland Awaiting requested review from elland

@stephen-smith stephen-smith Awaiting requested review from stephen-smith

@pcapriotti pcapriotti Awaiting requested review from pcapriotti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smatting @pcapriotti