Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQSERVICES-1628-dont-allow-deleting-id-ps-if-the-deleting-user-is-authenticated-by-it #2519

Merged
merged 5 commits into from
Jun 29, 2022
Merged

SQSERVICES-1628-dont-allow-deleting-id-ps-if-the-deleting-user-is-authenticated-by-it #2519

merged 5 commits into from
Jun 29, 2022

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Jun 28, 2022 •
edited

https://wearezeta.atlassian.net/browse/SQSERVICES-1628

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@battermann battermann temporarily deployed to cachix June 28, 2022 10:47 Inactive
@battermann battermann temporarily deployed to cachix June 28, 2022 10:49 Inactive
@battermann battermann requested a review from fisx June 28, 2022 10:50
fisx
fisx approved these changes Jun 28, 2022
View reviewed changes
services/spar/src/Spar/API.hs Outdated Show resolved Hide resolved
services/spar/src/Spar/Error.hs Outdated Show resolved Hide resolved
@battermann @fisx
Update services/spar/src/Spar/API.hs
7749597 
Co-authored-by: fisx <mf@zerobuzz.net>
@battermann battermann temporarily deployed to cachix June 28, 2022 13:04 Inactive
@battermann @fisx
Update services/spar/src/Spar/Error.hs
ca98662 
Co-authored-by: fisx <mf@zerobuzz.net>
@battermann battermann temporarily deployed to cachix June 28, 2022 13:05 Inactive
@battermann battermann temporarily deployed to cachix June 28, 2022 14:35 Inactive
@battermann battermann merged commit f244af0 into develop Jun 29, 2022
@battermann battermann deleted the SQSERVICES-1628-dont-allow-deleting-id-ps-if-the-deleting-user-is-authenticated-by-it branch June 29, 2022 07:30
This was referenced Jul 5, 2022
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@battermann @fisx