Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coturn multi-tenancy support #2553

Merged
merged 2 commits into from
Jul 13, 2022
Merged

coturn multi-tenancy support #2553

merged 2 commits into from
Jul 13, 2022

Conversation

sysvinit
Copy link
Contributor

This change updates the coturn Helm chart to add support for passing multiple authentication secrets to coturn. This makes it possible to operate a multi-tenant TURN service without needing to share secrets between consumers.

coturn already supports multiple auth secrets, so this change just adds the necessary configuration machinery to the Helm chart.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If HTTP endpoint paths have been added or renamed, or feature configs have changed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@sysvinit sysvinit temporarily deployed to cachix July 12, 2022 11:01 Inactive
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Just one question...

charts/coturn/templates/secret.yaml Show resolved Hide resolved
@sysvinit sysvinit merged commit 6ee2a66 into develop Jul 13, 2022
@sysvinit sysvinit deleted the sysvinit/coturn-multitenancy branch July 13, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants