Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqservices 1662 be internal patch team features #2555

Merged
merged 12 commits into from
Jul 14, 2022
Merged

Sqservices 1662 be internal patch team features #2555

merged 12 commits into from
Jul 14, 2022

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Jul 12, 2022 •
edited

https://wearezeta.atlassian.net/browse/SQSERVICES-1662

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@battermann battermann temporarily deployed to cachix July 12, 2022 14:57 Inactive
@battermann battermann temporarily deployed to cachix July 12, 2022 15:04 Inactive
@battermann battermann temporarily deployed to cachix July 13, 2022 06:50 Inactive
@battermann battermann temporarily deployed to cachix July 13, 2022 06:55 Inactive
@battermann battermann temporarily deployed to cachix July 13, 2022 06:56 Inactive
@battermann battermann temporarily deployed to cachix July 13, 2022 07:01 Inactive
@battermann battermann marked this pull request as ready for review July 13, 2022 07:06
@battermann battermann requested review from smatting and fisx July 13, 2022 07:06
smatting
smatting approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@smatting smatting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@battermann battermann merged commit c7cf1a5 into develop Jul 14, 2022
@battermann battermann deleted the SQSERVICES-1662-be-internal-patch-team-features branch July 14, 2022 13:55
@zebot zebot mentioned this pull request Jul 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smatting smatting smatting approved these changes

@fisx fisx Awaiting requested review from fisx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@battermann @smatting