Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FS-806] Add a Timestamp to the MLS Message Endpoint #2560

Merged
merged 4 commits into from
Jul 15, 2022
Merged

[FS-806] Add a Timestamp to the MLS Message Endpoint #2560

merged 4 commits into from
Jul 15, 2022

Conversation

mdimjasevic
Copy link
Contributor

The PR adds a timestamp in the response to the POST /mls/messages endpoint. This is a breaking API change going from v1 to the current development version v2.

Tracked by https://wearezeta.atlassian.net/browse/FS-806.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@mdimjasevic
Move the Epoch type to a separate module
ee9d82c 
- This should help with avoiding a dependency cycle in upcoming changes
@mdimjasevic mdimjasevic temporarily deployed to cachix July 14, 2022 08:52 Inactive
@mdimjasevic mdimjasevic marked this pull request as draft July 14, 2022 09:08
@mdimjasevic mdimjasevic temporarily deployed to cachix July 14, 2022 09:17 Inactive
@mdimjasevic mdimjasevic marked this pull request as ready for review July 14, 2022 09:18
@mdimjasevic
Merge remote-tracking branch 'origin/develop' into fs-806/mls-message…
cdd3987 
…-timestamp

This also performs a bit of alphabetical sorting on effect lists in
various types.
@mdimjasevic mdimjasevic temporarily deployed to cachix July 15, 2022 07:44 Inactive
@mdimjasevic mdimjasevic merged commit afcc2ae into develop Jul 15, 2022
@mdimjasevic mdimjasevic deleted the fs-806/mls-message-timestamp branch July 15, 2022 09:58
@zebot zebot mentioned this pull request Jul 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanwire stefanwire stefanwire approved these changes

@smatting smatting Awaiting requested review from smatting

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdimjasevic @stefanwire