Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for urls in team invitations (SQPIT-1368) #2797

Merged
merged 5 commits into from
Nov 4, 2022

Conversation

supersven
Copy link
Contributor

@supersven supersven commented Oct 25, 2022

If team invitation urls are rendered in the response of a team invitation request depends on the settings of galley. Because these cannot be changed during test runs, we first left this test out. This PR adds a test with a mocked instance of galley (such that the configuration change can be simulated).

https://wearezeta.atlassian.net/browse/SQPIT-1368

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 25, 2022
@supersven supersven force-pushed the sventennie/add-invitation-url-test branch from a182dbe to 02a1ceb Compare October 25, 2022 15:02
@supersven supersven temporarily deployed to cachix October 25, 2022 15:02 Inactive
@supersven supersven changed the title Add test for urls in team invitations Add test for urls in team invitations (SQPIT-1368) Oct 25, 2022
@supersven supersven temporarily deployed to cachix October 25, 2022 15:20 Inactive
@supersven supersven temporarily deployed to cachix October 25, 2022 15:37 Inactive
@supersven supersven marked this pull request as ready for review October 26, 2022 10:08
@supersven supersven requested a review from fisx October 26, 2022 10:09
services/brig/test/integration/API/Team.hs Outdated Show resolved Hide resolved
@supersven supersven force-pushed the sventennie/add-invitation-url-test branch from d8fa93b to 1d71554 Compare November 2, 2022 16:37
@supersven supersven temporarily deployed to cachix November 2, 2022 16:37 Inactive
@supersven supersven temporarily deployed to cachix November 3, 2022 07:35 Inactive
@supersven supersven merged commit 6016560 into develop Nov 4, 2022
@supersven supersven deleted the sventennie/add-invitation-url-test branch November 4, 2022 10:46
supersven added a commit that referenced this pull request Nov 22, 2022
Add tests for invitation urls in team invitation responses. These depend on the settings of galley.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants