remove buildah references

Makefile

@@ -14,9 +14,7 @@ CHARTS_INTEGRATION    := wire-server databases-ephemeral redis-cluster fake-aws
 # this list could be generated from the folder names under ./charts/ like so:
 # CHARTS_RELEASE := $(shell find charts/ -maxdepth 1 -type d | xargs -n 1 basename | grep -v charts)
 CHARTS_RELEASE        := wire-server redis-ephemeral redis-cluster databases-ephemeral fake-aws fake-aws-s3 fake-aws-sqs aws-ingress  fluent-bit kibana backoffice calling-test demo-smtp elasticsearch-curator elasticsearch-external elasticsearch-ephemeral minio-external cassandra-external nginx-ingress-controller nginx-ingress-services reaper sftd restund coturn inbucket
-BUILDAH_PUSH          ?= 0
 KIND_CLUSTER_NAME     := wire-server
-BUILDAH_KIND_LOAD     ?= 1
 
 package ?= all
 EXE_SCHEMA := ./dist/$(package)-schema
@@ -409,24 +407,6 @@ upload-charts: charts-release
 echo-release-charts:
 	@echo ${CHARTS_RELEASE}
 
-.PHONY: buildah-docker
-buildah-docker: buildah-docker-nginz
-	./hack/bin/buildah-compile.sh all
-	BUILDAH_PUSH=${BUILDAH_PUSH} KIND_CLUSTER_NAME=${KIND_CLUSTER_NAME} BUILDAH_KIND_LOAD=${BUILDAH_KIND_LOAD}  ./hack/bin/buildah-make-images.sh
-
-.PHONY: buildah-docker-nginz
-buildah-docker-nginz:
-	BUILDAH_PUSH=${BUILDAH_PUSH} KIND_CLUSTER_NAME=${KIND_CLUSTER_NAME} BUILDAH_KIND_LOAD=${BUILDAH_KIND_LOAD}  ./hack/bin/buildah-make-images-nginz.sh
-
-.PHONY: buildah-docker-%
-buildah-docker-%:
-	./hack/bin/buildah-compile.sh $(*)
-	BUILDAH_PUSH=${BUILDAH_PUSH} EXECUTABLES=$(*) KIND_CLUSTER_NAME=${KIND_CLUSTER_NAME} BUILDAH_KIND_LOAD=${BUILDAH_KIND_LOAD} ./hack/bin/buildah-make-images.sh
-
-.PHONY: buildah-clean
-buildah-clean:
-	./hack/bin/buildah-clean.sh
-
 .PHONY: kind-cluster
 kind-cluster:
 	kind create cluster --name $(KIND_CLUSTER_NAME)

changelog.d/5-internal/buildah-drop-support

@@ -0,0 +1 @@
+Remove support for compiling local docker images with buildah. Nix is used to build docker images these days

docs/src/developer/developer/dependencies.md

@@ -254,12 +254,6 @@ Requirements:
 
 In both cases, you need to adjust the various integration configuration files and names so that this can work.
 
-## Buildah (optional)
-
-[Buildah](https://buildah.io/) is used for local docker image creation during development. See [buildah installation](https://github.com/containers/buildah/blob/master/install.md)
-
-See `make buildah-docker` for an entry point here.
-
 ## Helm chart development, integration tests in kubernetes
 
 You need `kubectl`, `helm`, `helmfile`, and a valid kubernetes context. Refer to https://docs.wire.com for details.

docs/src/developer/developer/how-to.md

@@ -108,10 +108,10 @@ FUTUREWORK: this process is in development (update this section after it's confi
 
 ##### (i) Build images
 
-1. Ensure `buildah` is available on your system.
-2. Compile the image using `make buildah-docker`. This will try to upload the
-   images into a `kind` cluster. If you'd prefer uploading images to quay.io,
-   you can run it with `make buildah-docker BUILDAH_PUSH=1 BUILDAH_KIND_LOAD=0`
+(FUTUREWORK: implement a convenient shortcut to build images without actually uploading them also)
+```
+make upload-images-dev
+```
 
 ##### (ii) Run tests in kind
 
@@ -120,7 +120,6 @@ FUTUREWORK: this process is in development (update this section after it's confi
 2. Run tests using `make kind-integration-test`.
 3. Run end2end integration tests: `make kind-integration-e2e`.
 
-NOTE: debug this process further as some images (e.g. nginz) are missing from the default buildah steps.
 * Implement re-tagging development tags as your user tag?
 
 #### 2.4 Deploy your local code to a kubernetes cluster
@@ -138,9 +137,7 @@ make kube-integration-setup
 Then build and push the `brig` image by running
 
 ```
-export DOCKER_TAG_LOCAL_BUILD=$USER
-hack/bin/buildah-compile.sh all
-DOCKER_TAG=$DOCKER_TAG_LOCAL_BUILD EXECUTABLES=brig BUILDAH_PUSH=1 ./hack/bin/buildah-make-images.sh
+#FUTUREWORK
 ```
 
 To update the release with brig's local image run