Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FS-925] Lazily create an MLS Self-conversation #2839

Merged
merged 8 commits into from
Nov 18, 2022

Conversation

mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Nov 9, 2022

This is a follow-up to #2730.

It changes the introduced endpoint's method from PUT to GET. Furthermore, it creates the self-conversation on the first call to the GET endpoint, but such that the epoch column is not written to so as to avoid undesired race conditions of another client also creating the conversation and bumping the epoch number (the rest of the columns in the conversation record are identical, so there is no harm in overwriting such columns). The epoch number is actually written to the database only upon the first commit.

Checklist

  • See if there are additional checks that should be done when inserting the creator client's key package ref
  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@mdimjasevic mdimjasevic force-pushed the fs-926/method-change-from-get-to-put branch from 650cbb9 to 1c9c019 Compare November 10, 2022 16:01
@mdimjasevic mdimjasevic temporarily deployed to cachix November 10, 2022 16:01 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 10, 2022 16:02 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Nov 10, 2022
@mdimjasevic mdimjasevic force-pushed the fs-926/method-change-from-get-to-put branch from 1c9c019 to af30d9b Compare November 14, 2022 10:19
@mdimjasevic mdimjasevic temporarily deployed to cachix November 14, 2022 10:19 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 14, 2022 10:19 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 16, 2022 15:21 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 16, 2022 15:21 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 16, 2022 16:03 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 16, 2022 16:03 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 17, 2022 09:09 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 17, 2022 09:09 Inactive
@mdimjasevic mdimjasevic marked this pull request as ready for review November 17, 2022 09:10
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo comments below.

services/galley/src/Galley/API/MLS/Message.hs Outdated Show resolved Hide resolved
services/galley/src/Galley/Cassandra/Conversation.hs Outdated Show resolved Hide resolved
services/galley/src/Galley/Cassandra/Conversation.hs Outdated Show resolved Hide resolved
@mdimjasevic mdimjasevic temporarily deployed to cachix November 18, 2022 11:05 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix November 18, 2022 11:05 Inactive
@mdimjasevic mdimjasevic merged commit 8fcfe87 into develop Nov 18, 2022
@mdimjasevic mdimjasevic deleted the fs-926/method-change-from-get-to-put branch November 18, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants