AWS/SNS create endpoint without custom user data (SQCORE-1267) #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tomUserData (SQCORE-1267) We need these trace logs to understand how AWS/SNS exactly behaves. (Unfortunately, the documentation is a bit sparse.) The sent CustomUserData used to be the UserId. This doesn't make sense anymore; given that a user may be attached with the same device (Android or iOS) and several accounts to the same backend.
zebot
added
the
ok-to-test
tmspzz
approved these changes
Dec 8, 2022
supersven
deleted the
sventennie/SNS_create_endpoint_without_CustomUserData
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, AWS/SNS endpoint creation included
CustomUserDatawhich was theUserId. This doesn't make sense anymore; given that a user may be attached with the same device (Android or iOS) and several accounts (severalUserIds!) to the same backend. So,CustomUserDataisn't added to the request, anymore.This PR is experimental, as we have to check if it doesn't break anything on
staging. (Unfortunately, that's the only environment for these kind of tests that we've at hand... 😞 )This PR also includes trace logging (== logs with level
Trace) of requests and responses sent dururing SNS endpoint creation.Ticket
SQCORE-1267
Checklist
changelog.d