Add an Imports.hs module #440
Conversation
| import Database.Redis.IO hiding (Milliseconds) | ||
| import Gundeck.Monad (Gundeck, posixTime) | ||
| import Gundeck.Types | ||
| import Gundeck.Util.Redis | ||
|
|
||
| import qualified Data.ByteString as Strict |
There was a problem hiding this comment.
SBS instead of Strict? not important.
another idea:
$(importQualifiedDefaults)Which expands to a list of qualified imports we usually want. I guess the problem is that this would trigger unused import warnings? Also not important. :-) And we can always do that another time.
There was a problem hiding this comment.
TH can't generate imports
There was a problem hiding this comment.
this problem (preludes can't provide qualified imports) has no solution AFAIK; you can use #includes but then you have to turn off the "unused imports" warning, true
There was a problem hiding this comment.
Yes, i've used CPP in my last project, and the results are inconclusive. I think the other(s) liked it, I was skeptical.
Ok, no default qualified imports for now then!
| import Database.Redis.IO | ||
|
|
||
| import qualified Data.ByteString.Lazy as BSL |
There was a problem hiding this comment.
(LBS? i like the aliases from string-conversions. :-) )
|
@tiago-loureiro I think this can be merged now, can you un-reject? |
* Add Imports and migrate cargohold, gundeck, proxy * Fix warnings * Rebuild
Just putting it out there so that nobody tries to do it on their own.
Let's definitely not merge it before LTS pull-requests.