Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack yaml #479

Merged
merged 3 commits into from
Oct 6, 2018
Merged

Fix stack yaml #479

merged 3 commits into from
Oct 6, 2018

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Oct 5, 2018

No description provided.

lts-11.13 has tasty-1.0.1.1, not 1.0.0.1.  weirdly, the older version
led to compilation errors in brig integration tests.  i have no
explanation for why this didn't show up in #478.
@neongreen
Copy link
Contributor

neongreen commented Oct 5, 2018

That's unfortunate timing :( The alpine-builder has almost finished.

I will kill the Concourse jobs created by this PR and then ask you to push an empty commit or amend one of these two.

@neongreen
Copy link
Contributor

Hm, or actually I should be able to just restart the job for you.

@fisx
Copy link
Contributor Author

fisx commented Oct 5, 2018

Hm, or actually I should be able to just restart the job for you.

Thanks! :-) (in case it matters, I won't need this before Monday. Good night..)

@fisx fisx requested a review from neongreen October 5, 2018 20:59
@neongreen
Copy link
Contributor

@fisx do you mind if I also merge this after the tests pass?

@fisx
Copy link
Contributor Author

fisx commented Oct 6, 2018

@fisx do you mind if I also merge this after the tests pass?

go ahead, i was meaning to ask you anyway. and if you forget it's fine with me, too.

@neongreen neongreen merged commit bfd8756 into develop Oct 6, 2018
@neongreen neongreen deleted the fix-stack-yaml branch October 6, 2018 19:14
king6cong pushed a commit to king6cong/wire-server that referenced this pull request Oct 12, 2018
* Fix stack.yaml: drop redundant version pinning.

* Fix stack.yaml: drop outdated version pinning.

lts-11.13 has tasty-1.0.1.1, not 1.0.0.1.  weirdly, the older version
led to compilation errors in brig integration tests.  i have no
explanation for why this didn't show up in wireapp#478.

* Trigger CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants