Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics middleware to spar. #498

Merged
merged 3 commits into from Oct 24, 2018
Merged

Add metrics middleware to spar. #498

merged 3 commits into from Oct 24, 2018

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Oct 23, 2018

tasks:

  • make sure /metrics is the right URI path, or change it.
  • add integration test that checks that metrics are generated?
  • see if we have all the generate all any data at all, or all the data we want.

@fisx
Copy link
Contributor Author

fisx commented Oct 24, 2018

$ curl http://localhost:8088/i/monitoring
# HELP http_request_duration_seconds The HTTP request latencies in seconds.
# TYPE http_request_duration_seconds histogram
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="200",le="0.005"} 18
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="200",le="0.01"} 23
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="200",le="0.025"} 24
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="200",le="0.05"} 24
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="200",le="0.1"} 24
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="200",le="0.25"} 24
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="200",le="0.5"} 24
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="200",le="1.0"} 24
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="200",le="2.5"} 24
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="200",le="5.0"} 24
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="200",le="10.0"} 24
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="200",le="+Inf"} 24
http_request_duration_seconds_sum{handler="app",method="GET",status_code="200"} 7.236669000000001e-2
http_request_duration_seconds_count{handler="app",method="GET",status_code="200"} 24
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="404",le="0.005"} 1
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="404",le="0.01"} 1
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="404",le="0.025"} 1
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="404",le="0.05"} 1
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="404",le="0.1"} 1
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="404",le="0.25"} 1
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="404",le="0.5"} 1
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="404",le="1.0"} 1
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="404",le="2.5"} 1
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="404",le="5.0"} 1
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="404",le="10.0"} 1
http_request_duration_seconds_bucket{handler="app",method="GET",status_code="404",le="+Inf"} 1
http_request_duration_seconds_sum{handler="app",method="GET",status_code="404"} 2.39014e-3
http_request_duration_seconds_count{handler="app",method="GET",status_code="404"} 1
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="200",le="0.005"} 1
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="200",le="0.01"} 3
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="200",le="0.025"} 3
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="200",le="0.05"} 3
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="200",le="0.1"} 3
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="200",le="0.25"} 3
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="200",le="0.5"} 3
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="200",le="1.0"} 3
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="200",le="2.5"} 3
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="200",le="5.0"} 3
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="200",le="10.0"} 3
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="200",le="+Inf"} 3
http_request_duration_seconds_sum{handler="app",method="HEAD",status_code="200"} 2.0847349e-2
http_request_duration_seconds_count{handler="app",method="HEAD",status_code="200"} 3
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="404",le="0.005"} 1
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="404",le="0.01"} 1
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="404",le="0.025"} 1
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="404",le="0.05"} 1
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="404",le="0.1"} 1
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="404",le="0.25"} 1
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="404",le="0.5"} 1
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="404",le="1.0"} 1
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="404",le="2.5"} 1
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="404",le="5.0"} 1
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="404",le="10.0"} 1
http_request_duration_seconds_bucket{handler="app",method="HEAD",status_code="404",le="+Inf"} 1
http_request_duration_seconds_sum{handler="app",method="HEAD",status_code="404"} 9.2561e-4
http_request_duration_seconds_count{handler="app",method="HEAD",status_code="404"} 1
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="200",le="0.005"} 0
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="200",le="0.01"} 0
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="200",le="0.025"} 0
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="200",le="0.05"} 2
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="200",le="0.1"} 3
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="200",le="0.25"} 4
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="200",le="0.5"} 4
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="200",le="1.0"} 4
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="200",le="2.5"} 4
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="200",le="5.0"} 4
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="200",le="10.0"} 4
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="200",le="+Inf"} 4
http_request_duration_seconds_sum{handler="app",method="POST",status_code="200"} 0.37673793699999997
http_request_duration_seconds_count{handler="app",method="POST",status_code="200"} 4
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="201",le="0.005"} 0
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="201",le="0.01"} 0
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="201",le="0.025"} 1
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="201",le="0.05"} 2
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="201",le="0.1"} 2
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="201",le="0.25"} 2
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="201",le="0.5"} 2
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="201",le="1.0"} 2
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="201",le="2.5"} 2
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="201",le="5.0"} 2
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="201",le="10.0"} 2
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="201",le="+Inf"} 2
http_request_duration_seconds_sum{handler="app",method="POST",status_code="201"} 4.2691357e-2
http_request_duration_seconds_count{handler="app",method="POST",status_code="201"} 2
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="404",le="0.005"} 1
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="404",le="0.01"} 1
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="404",le="0.025"} 1
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="404",le="0.05"} 1
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="404",le="0.1"} 1
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="404",le="0.25"} 1
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="404",le="0.5"} 1
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="404",le="1.0"} 1
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="404",le="2.5"} 1
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="404",le="5.0"} 1
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="404",le="10.0"} 1
http_request_duration_seconds_bucket{handler="app",method="POST",status_code="404",le="+Inf"} 1
http_request_duration_seconds_sum{handler="app",method="POST",status_code="404"} 3.577483e-3
http_request_duration_seconds_count{handler="app",method="POST",status_code="404"} 1
http_request_duration_seconds_bucket{handler="prometheus",method="GET",status_code="200",le="0.005"} 13
http_request_duration_seconds_bucket{handler="prometheus",method="GET",status_code="200",le="0.01"} 13
http_request_duration_seconds_bucket{handler="prometheus",method="GET",status_code="200",le="0.025"} 13
http_request_duration_seconds_bucket{handler="prometheus",method="GET",status_code="200",le="0.05"} 13
http_request_duration_seconds_bucket{handler="prometheus",method="GET",status_code="200",le="0.1"} 13
http_request_duration_seconds_bucket{handler="prometheus",method="GET",status_code="200",le="0.25"} 13
http_request_duration_seconds_bucket{handler="prometheus",method="GET",status_code="200",le="0.5"} 13
http_request_duration_seconds_bucket{handler="prometheus",method="GET",status_code="200",le="1.0"} 13
http_request_duration_seconds_bucket{handler="prometheus",method="GET",status_code="200",le="2.5"} 13
http_request_duration_seconds_bucket{handler="prometheus",method="GET",status_code="200",le="5.0"} 13
http_request_duration_seconds_bucket{handler="prometheus",method="GET",status_code="200",le="10.0"} 13
http_request_duration_seconds_bucket{handler="prometheus",method="GET",status_code="200",le="+Inf"} 13
http_request_duration_seconds_sum{handler="prometheus",method="GET",status_code="200"} 1.245389e-3
http_request_duration_seconds_count{handler="prometheus",method="GET",status_code="200"} 13

@fisx fisx requested a review from jschaul October 24, 2018 07:04
@fisx fisx changed the title [WIP] Add metrics middleware to spar. Add metrics middleware to spar. Oct 24, 2018
@tiago-loureiro tiago-loureiro requested review from tiago-loureiro and removed request for jschaul October 24, 2018 09:38
@fisx fisx merged commit 8881b52 into develop Oct 24, 2018
@fisx fisx deleted the fisx-spar-monitoring branch October 24, 2018 09:48
@fisx fisx mentioned this pull request Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants