-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to make the demo runnable from Docker #571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! There are some minor comments, see inline. Perhaps you could also add a line to the services-demo/README.md
that mentions the ./demo.sh docker
usage?
I tried your branch with the review fixes, re-compiled the nginz docker image using make docker
using these changes, and the docker-based demo works for me in the sense that swagger-ui is available under http://127.0.0.1:8080/swagger-ui/.
and also ensure consistent tagging in Docker builds
Yep, thanks, added a note on it to that README.md
I've pulled all the changes from upstream
I also can access Swagger UI on http://127.0.0.1:8080/swagger-ui/, however when I generate email/password pair using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try the change inline to see if that solves your swagger missing files problem? Otherwise, this PR looks good.
Co-Authored-By: romanrev <revrom+github@gmail.com>
thanks a lot, it's all working now! |
Thanks @romanrev for your contribution! |
Please refer to the issue #564
I was able to successfully launch the demo by running the
deploy/docker-ephemeral/run.sh
in one terminal and./deploy/services-demo/demo.sh docker
in another terminal, however I am not able to login at http://127.0.0.1:8080/swagger-ui yet, with an email/password generated using the process outlined in the documentation, getting the following errors in the console: