Make adding users implicit in CreateConversation permission. #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,7 +84,6 @@ createTeamGroupConv zusr zcon tinfo body = do | |||
| let uu = filter (/= zusr) $ map (view userId) mems | |||
| checkedConvSize uu | |||
| else do | |||
| void $ permissionCheck zusr AddRemoveConvMember mems | |||
There was a problem hiding this comment.
Let's change this into sth like: if user has no AddConvMember permission, then ensure size <= 1
tiago-loureiro
previously requested changes
Jan 21, 2019
it's a change in plan that clients should limit the kinds of conversations a collaborator can create, but that seems fine. i have no strong opinion either way. |
tiago-loureiro
approved these changes
Jan 22, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this, collaborators can only create empty conversations, but they need to create 1:1 convs, too.